Update autolabeler config to match any file with gradle in it #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For anybody who looked at the demo PRs in my peronal repo, notw that 've already overwritten the master branch to match the apache master. In order for the tags to be applied, the autolabeler config needs to be updated first and then changes will show up (they can't typically be intermixed in the same PR like the PRs in my personal repo make it look). |
Contributor
|
Thanks, @kbendick! |
Contributor
Author
No problem. Thank you for noticing this bug and tagging me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in this PR, #1423, changes to the
build.gradlefile were not properly handled by the autolabeler.I have updated the autolabeler config to handle this case. I've also merged this into my local repo in order to test for this.
I validated the change on a top level file named
gradle.properties(to check both top level files as well as files with only the substing gradle) in this PR in my local repo.I also tested against the build.gradle file, as that was the original file and it differed from the previous one in that
gradleis now the ending substring (checking padding on either side).I also performed two checks for files in the
gradledirectory, one that checks on a file with gradle in the name and one that checks solely on a change that matches the gradle dir in the path, with no gradle in the file name.Suffice it to say that this has ben pretty pedantically checked 😅 .
This PR closes this issue: #1447
cc @rdblue who noticed that the file didn't match. Thank you for that!